Conversation
Member
sfujiwara
requested changes
Dec 21, 2019
Member
sfujiwara
left a comment
sfujiwara
left a comment
There was a problem hiding this comment.
ash が明示的に指定されていて Docker を使わずに直接 ./bin/run を実行した時に動かないので
- Suggestion のような感じで
#!/bin/shで指定する - Docker を使った実行のみサポートする方針にする
- この場合は
README.mdから "Without Docker" の項目を削除する
- この場合は
のいずれかの対応が必要そうです。
どちらの方針もありだと思うので、好きな方を選んじゃって良いかと。
その他の動作確認は大丈夫そうでした。
Member
|
メンションをつけ忘れていた |
Closed
Co-Authored-By: Shuhei Fujiwara <shuhei.fujiwara@gmail.com>
Co-Authored-By: Shuhei Fujiwara <shuhei.fujiwara@gmail.com>
Co-Authored-By: Shuhei Fujiwara <shuhei.fujiwara@gmail.com>
Co-Authored-By: Shuhei Fujiwara <shuhei.fujiwara@gmail.com>
Co-Authored-By: Shuhei Fujiwara <shuhei.fujiwara@gmail.com>
chie8842
force-pushed
the
feature/diff-chie8842
branch
from
5afb344 to
dd04378
Compare
Collaborator
Author
|
ありがとうございます！suggestion反映したのと、READMEを少し修正しました🙏 |
Member
|
あああ！ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sfujiwara スクリプトですが、なるべく重複部分をなくしたかったので、
わたしがこうしたいな、と思うように少し変えてみました！
どうでしょうか？
修正点：